chore: replace `github.com/ghodss/yaml` with `sigs.k8s.io/yaml` by Juneezee · Pull Request #13292 · argoproj/argo-cd

Juneezee · 2023-04-19T15:04:12Z

The github.com/ghodss/yaml package is no longer actively maintained. sigs.k8s.io/yaml is a permanent fork of github.com/ghodss/yaml. It is actively maintained by Kubernetes SIG, and also widely used in K8s projects.

The notable change is that github.com/ghodss/yaml uses gopkg.in/yaml.v2 v2.2.2, but sigs.k8s.io/yaml uses gopkg.in/yaml.v2 v2.4.0. Changes can be seen here v2.2.2...v2.4.0, mostly bug fixes.

I also ran go mod tidy.

Checklist:

At the time of making this commit, the package `github.com/ghodss/yaml` is no longer actively maintained. `sigs.k8s.io/yaml` is a permanent fork of `ghodss/yaml` and is actively maintained by Kubernetes SIG. Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>

codecov · 2023-04-19T15:18:49Z

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (ceed653) 49.01% compared to head (c3926b3) 49.01%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #13292      +/-   ##
==========================================
- Coverage   49.01%   49.01%   -0.01%     
==========================================
  Files         247      247              
  Lines       42685    42685              
==========================================
- Hits        20924    20921       -3     
- Misses      19645    19647       +2     
- Partials     2116     2117       +1

Impacted Files	Coverage Δ
cmd/argocd/commands/account.go	`0.00% <ø> (ø)`
cmd/argocd/commands/admin/admin.go	`15.33% <ø> (ø)`
cmd/argocd/commands/admin/app.go	`31.12% <ø> (ø)`
cmd/argocd/commands/admin/backup.go	`0.00% <ø> (ø)`
cmd/argocd/commands/admin/generatespec_utils.go	`59.15% <ø> (ø)`
cmd/argocd/commands/admin/project_allowlist.go	`32.07% <ø> (ø)`
cmd/argocd/commands/admin/settings.go	`67.50% <ø> (ø)`
cmd/argocd/commands/admin/settings_rbac.go	`24.48% <ø> (ø)`
cmd/argocd/commands/app.go	`22.00% <ø> (ø)`
cmd/argocd/commands/app_actions.go	`0.00% <ø> (ø)`
... and 13 more

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

blakepettersson · 2023-04-20T08:18:51Z

Looks great! It would also be good to update the notification-engine as well.

Juneezee · 2023-04-20T09:02:42Z

Looks great! It would also be good to update the notification-engine as well.

@blakepettersson Please also review argoproj/notifications-engine#175. I'll update this PR once that has been merged. Thanks

crenshaw-dev

Thanks, @Juneezee!

crenshaw-dev · 2023-05-04T22:07:22Z

@Juneezee once the notifications-engine fix is in, we can open another PR to bump the notifications-engine version. :-)

At the time of making this commit, the package `github.com/ghodss/yaml` is no longer actively maintained. `sigs.k8s.io/yaml` is a permanent fork of `ghodss/yaml` and is actively maintained by Kubernetes SIG. Reference: argoproj/argo-cd#13292 (comment) Signed-off-by: Eng Zer Jun <engzerjun@gmail.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

In the same vein as argoproj#13292, since `github.com/ghodss/yaml` is no longer maintained. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

* feat: values can be either a string or a map Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * Allow viewing and editing values Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * fix golang lint Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * fix codegen make build green Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * Add special cases for handling nil/empty string. strip newline at end of generated yaml. fix unittests Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * Add tests. Fix e2e marshalJSON Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * fix codegen. make codegen and make codegen-local give different results to me Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * Update helm_test.go Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * Fix UI - validate input Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * change implementation; introduce valuesObject instead of values Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * More generated files. Fix tests Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * Fix eslint Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * chore: make codegen Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: use sigs.k8s.io/yaml In the same vein as #13292, since `github.com/ghodss/yaml` is no longer maintained. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: compact values Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: make manifests Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * docs: add to helm user guide Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * docs: remove any deprecation mentions Remove any mentions that `Values` is deprecated, for now. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: make codegen Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * test: add assertion verify that valuesobject overrides values by checking the number of replicas. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * test: remove assertion This wasn't meant to be in there, was a typo. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: minor nit fix Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> --------- Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Blake Pettersson <blake.pettersson@gmail.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* self-service from event * chore: replace github.com/ghodss/yaml with sigs.k8s.io/yaml (#175) At the time of making this commit, the package `github.com/ghodss/yaml` is no longer actively maintained. `sigs.k8s.io/yaml` is a permanent fork of `ghodss/yaml` and is actively maintained by Kubernetes SIG. Reference: argoproj/argo-cd#13292 (comment) Signed-off-by: Eng Zer Jun <engzerjun@gmail.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * feat: Adding new PagerDuty integration based on Events API v2 (#105) Signed-off-by: Eric Tendian <erictendian@gmail.com> * self-service from event * self-service from event * self-service from event * self-service from event * self-service from event * clean up factory.go * error handleing in factory.go * error handleing in factory.go * error handleing in factory.go * error handleing in factory.go * error handleing in factory.go * error handleing in factory.go * error handleing in factory.go * better caching * better caching * refactor Signed-off-by: zachaller <zachaller@users.noreply.github.com> * unused Signed-off-by: zachaller <zachaller@users.noreply.github.com> * lint Signed-off-by: zachaller <zachaller@users.noreply.github.com> * bump ci Signed-off-by: zachaller <zachaller@users.noreply.github.com> * small fixes Signed-off-by: zachaller <zachaller@users.noreply.github.com> * rename Signed-off-by: zachaller <zachaller@users.noreply.github.com> * rename Signed-off-by: zachaller <zachaller@users.noreply.github.com> * rename Signed-off-by: zachaller <zachaller@users.noreply.github.com> * change log line Signed-off-by: zachaller <zachaller@users.noreply.github.com> * update tests Signed-off-by: zachaller <zachaller@users.noreply.github.com> * continue on error Signed-off-by: zachaller <zachaller@users.noreply.github.com> * continue on errors Signed-off-by: zachaller <zachaller@users.noreply.github.com> * add godoc Signed-off-by: zachaller <zachaller@users.noreply.github.com> * continue on error Signed-off-by: zachaller <zachaller@users.noreply.github.com> * fix error by going back to non namespace support Signed-off-by: zachaller <zachaller@users.noreply.github.com> * fix log Signed-off-by: zachaller <zachaller@users.noreply.github.com> * improve log on error Signed-off-by: zachaller <zachaller@users.noreply.github.com> --------- Signed-off-by: Eng Zer Jun <engzerjun@gmail.com> Signed-off-by: Eric Tendian <erictendian@gmail.com> Signed-off-by: zachaller <zachaller@users.noreply.github.com> Co-authored-by: May Zhang <may_zhang@intuit.com> Co-authored-by: Eng Zer Jun <engzerjun@gmail.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Eric Tendian <erictendian@gmail.com>

…proj#13292) At the time of making this commit, the package `github.com/ghodss/yaml` is no longer actively maintained. `sigs.k8s.io/yaml` is a permanent fork of `ghodss/yaml` and is actively maintained by Kubernetes SIG. Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>

… (argoproj#11538) * feat: values can be either a string or a map Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * Allow viewing and editing values Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * fix golang lint Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * fix codegen make build green Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * Add special cases for handling nil/empty string. strip newline at end of generated yaml. fix unittests Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * Add tests. Fix e2e marshalJSON Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * fix codegen. make codegen and make codegen-local give different results to me Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * Update helm_test.go Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * Fix UI - validate input Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * change implementation; introduce valuesObject instead of values Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * More generated files. Fix tests Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * Fix eslint Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * chore: make codegen Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: use sigs.k8s.io/yaml In the same vein as argoproj#13292, since `github.com/ghodss/yaml` is no longer maintained. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: compact values Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: make manifests Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * docs: add to helm user guide Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * docs: remove any deprecation mentions Remove any mentions that `Values` is deprecated, for now. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: make codegen Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * test: add assertion verify that valuesobject overrides values by checking the number of replicas. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * test: remove assertion This wasn't meant to be in there, was a typo. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: minor nit fix Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> --------- Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Blake Pettersson <blake.pettersson@gmail.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

Juneezee mentioned this pull request Apr 20, 2023

chore: replace github.com/ghodss/yaml with sigs.k8s.io/yaml argoproj/notifications-engine#175

Merged

blakepettersson added the ready-for-review An approver should give a final review and merge the PR label May 3, 2023

crenshaw-dev approved these changes May 4, 2023

View reviewed changes

crenshaw-dev merged commit e8331b4 into argoproj:master May 4, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: replace `github.com/ghodss/yaml` with `sigs.k8s.io/yaml`#13292

chore: replace `github.com/ghodss/yaml` with `sigs.k8s.io/yaml`#13292
crenshaw-dev merged 1 commit intoargoproj:masterfrom
Juneezee:chore/yaml

Juneezee commented Apr 19, 2023

Uh oh!

codecov bot commented Apr 19, 2023

Uh oh!

blakepettersson commented Apr 20, 2023

Uh oh!

Juneezee commented Apr 20, 2023 •

edited

Loading

Uh oh!

crenshaw-dev left a comment

Uh oh!

crenshaw-dev commented May 4, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Juneezee commented Apr 19, 2023

Uh oh!

codecov bot commented Apr 19, 2023

Codecov Report

Uh oh!

blakepettersson commented Apr 20, 2023

Uh oh!

Juneezee commented Apr 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

crenshaw-dev left a comment

Choose a reason for hiding this comment

Uh oh!

crenshaw-dev commented May 4, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Juneezee commented Apr 20, 2023 •

edited

Loading